Skip to content

ci(release): make sample sync non-blocking - #11

Merged
amasiye merged 1 commit into
mainfrom
develop
Aug 6, 2026
Merged

ci(release): make sample sync non-blocking#11
amasiye merged 1 commit into
mainfrom
develop

Conversation

@amasiye

@amasiye amasiye commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep release-version verification independent from sample synchronization
  • move the optional sample dispatch into its own release-triggered workflow
  • skip cleanly when credentials are absent and warn without invalidating an engine release when dispatch fails

Validation

  • workflow YAML parsed successfully
  • composer validate --strict
  • composer test -- --colors=never (196 tests, 991 assertions)

@amasiye
amasiye merged commit 4e75b20 into main Aug 6, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 081317fd1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +14
sync-samples:
runs-on: ubuntu-latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate sample dispatch on release-version verification

When a semantic-version release tag disagrees with the tagged revision's VERSION, verify-release-version.yml now fails independently while this job still posts engine-released to the samples repository. The previous needs: verify-release-version dependency prevented that invalid release from updating samples; keep dispatch failures non-blocking, but retain the version-match gate before sending the event.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant